acking-you commented on issue #11212: URL: https://github.com/apache/datafusion/issues/11212#issuecomment-2761086840
Thank you very much for your reply. These are some updates on this issue. @alamb: 1. I have added the extended SQL in this PR #15462, you can check the details there：[SQL link](https://github.com/acking-you/arrow-datafusion/tree/add_short_circuit/benchmarks/queries/clickbench#q6-how-many-social-shares-meet-complex-multi-stage-filtering-criteria) 2. The test results of the local extend SQL are as follows: ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ add_short_circuit ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 964.48ms │ 1006.79ms │ no change │ │ QQuery 1 │ 409.89ms │ 419.52ms │ no change │ │ QQuery 2 │ 838.25ms │ 868.74ms │ no change │ │ QQuery 3 │ 408.15ms │ 396.88ms │ no change │ │ QQuery 4 │ 1029.80ms │ 783.40ms │ +1.31x faster │ │ QQuery 5 │ 9429.76ms │ 8835.06ms │ +1.07x faster │ │ QQuery 6 │ 4096.47ms │ 1382.42ms │ +2.96x faster │ └──────────────┴───────────┴───────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 17176.80ms │ │ Total Time (add_short_circuit) │ 13692.80ms │ │ Average Time (main) │ 2453.83ms │ │ Average Time (add_short_circuit) │ 1956.11ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 4 │ └──────────────────────────────────┴────────────┘ ``` My question: Is there a pipeline in DataFusion that can automatically perform benchmark comparisons? 3. I'm currently encountering some issues mentioned in https://github.com/apache/datafusion/pull/15462#issuecomment-2760574284 and can't pass the tests yet. I'm trying to fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
