blaginin commented on PR #15256: URL: https://github.com/apache/datafusion/pull/15256#issuecomment-2758447609
Thank you! The feedback I saw in that discussion: - You asked if sqllogictests contribute to the coverage. Yes, here's the [example](https://app.codecov.io/gh/blaginin/datafusion/commit/805c70bfedac6bc6ae94e30baf2824cb16fb67b4/tree) (you can check sqllogictest-postgres) - @timsaucer and @tustvold highlighted that coverage itself is useless and that 95% coverage doesn't mean much. Definitely agree! That's why I disabled project-based code coverage status - the only one I care about is the diff in the PR code. i.e., if you submit a PR and some of your code isn't covered, it should help the reviewer to understand the current state and not overlook tests. - @mbutrovich raised a point about the license. In the DF repo itself, we only use the Codecov CLI to upload coverage. This isn't included in the DataFusion distribution itself and is under the Apache 2.0 license, so it should be fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
