qstommyshu commented on issue #15398: URL: https://github.com/apache/datafusion/issues/15398#issuecomment-2755795572
Hi @blaginin and @alamb Just want to confirm the example test files are really just "examples", right? I also see there are more files under the *subtrait* test cases (i.e. `emit_kind_test.rs`, `function_test.rc`,`logical_plans.rs`, etc...). I assume I should change all the test cases under the *subtrait* folder for this issue, not only the ones in [consumer_integration.rs](https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/substrait/tests/cases/consumer_integration.rs#L226-L229), and in [roundtrip_logical_plan.rs](https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L457-L462) Please let me know if my assumption is correct. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
