alamb commented on issue #15395: URL: https://github.com/apache/datafusion/issues/15395#issuecomment-2752511719
Here is a related ticket: - #2027 > Created an issue to ask what others think - the change is quite simple, but maybe there were previous discussions or consequences I don't see? I think @irenjj added similar code recently to support new duckdb style `tree` explain plans via `Expr::sql_name`: - https://github.com/apache/datafusion/pull/15253 However, it seems like the display is still somewhat 🤮 (I think b/c the column name is bad) ```sql > explain format tree select 3, array_length([1, 2, 4, 5, 10000, 2.4]);; +---------------+-------------------------------+ | plan_type | plan | +---------------+-------------------------------+ | physical_plan | ┌───────────────────────────┐ | | | │ ProjectionExec │ | | | │ -------------------- │ | | | │ Int64(3): 3 │ | | | │ │ | | | │ array_length(make_array │ | | | │ (Int64(1),Int64(2) │ | | | │ ,Int64(4),Int64(5) │ | | | │ ,Int64(10000),Float64 │ | | | │ (2.4))): │ | | | │ 6 │ | | | └─────────────┬─────────────┘ | | | ┌─────────────┴─────────────┐ | | | │ PlaceholderRowExec │ | | | └───────────────────────────┘ | | | | +---------------+-------------------------------+ 1 row(s) fetched. Elapsed 0.007 seconds. ``` Perhaps we should switch to `tree` by default as well as use `sql_name` for the column name 🤔 - https://github.com/apache/datafusion/issues/15343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
