xudong963 commented on code in PR #15379: URL: https://github.com/apache/datafusion/pull/15379#discussion_r2011266681
########## datafusion/datasource/src/file_groups.rs: ########## @@ -354,6 +361,115 @@ impl FileGroupPartitioner { } } +/// Represents a group of partitioned files that'll be processed by a single thread. +/// Maintains optional statistics across all files in the group. +#[derive(Debug, Clone)] +pub struct FileGroup { + /// The files in this group + pub files: Vec<PartitionedFile>, + /// Optional statistics for all files in the group + pub statistics: Option<Statistics>, Review Comment: done: https://github.com/apache/datafusion/pull/15379/commits/7415f7c6846b33136ee0c833c6836a3c97508b6b ########## datafusion/catalog-listing/src/helpers.rs: ########## @@ -121,40 +120,6 @@ pub fn expr_applicable_for_cols(col_names: &[&str], expr: &Expr) -> bool { /// The maximum number of concurrent listing requests const CONCURRENCY_LIMIT: usize = 100; -/// Partition the list of files into `n` groups -pub fn split_files( Review Comment: done https://github.com/apache/datafusion/pull/15379/commits/7415f7c6846b33136ee0c833c6836a3c97508b6b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org