zhuqi-lucas commented on PR #15348:
URL: https://github.com/apache/datafusion/pull/15348#issuecomment-2749930210

   > Thank you for the work on better Utf8View support. I tried one sort 
benchmark with sort-preserving merging on a single `Utf8View` column, but it 
gets slower:
   > 
   > Reproducer
   > 
   > ```
   > cargo run --profile release-nonlto --bin dfbench -- sort-tpch -p 
/Users/yongting/Code/datafusion/benchmarks/data/tpch_sf10 -q 3
   > ```
   > 
   > main: 8s pr: 10s
   > 
   > According to the flamegraph, an extra overhead of 
`libsystem_platform.dylib_platform_memcmp` showed up inside 
`SortPreservingMergeStream` It's not obvious why, I'll try to help figure it 
out later.
   > 
   > 
[flamegraphs.zip](https://github.com/user-attachments/files/19388551/flamegraphs.zip)
   
   This one also deserve a new ticket to investigation, created a ticket now:
   https://github.com/apache/datafusion/issues/15403
   
   cc @2010YOUY01 @alamb 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to