kazuyukitanimura opened a new pull request, #1569:
URL: https://github.com/apache/datafusion-comet/pull/1569

   ## Which issue does this PR close?
   
   ## Rationale for this change
   
   We have a name collision on `isCometEnabled`
   
   ```
   CometSparkSessionExtensions
   private[comet] def isCometEnabled(conf: SQLConf): Boolean = {
   ```
   and
   ```
   SQLTestUtilsBase
   protected def isCometEnabled: Boolean = SparkSession.isCometEnabled
   ```
   
   causing build issues depending on which one gets picked up
   ```
   [ERROR] 
/workspace/spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala:34:
 Boolean does not take parameters
   [ERROR] 
/workspace/spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala:42:
 Boolean does not take parameters
   [ERROR] 
/workspace/spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala:47:
 Boolean does not take parameters
   ```
   
   ## What changes are included in this PR?
   
   Renamed one to `isCometLoaded`
   
   ## How are these changes tested?
   
   CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to