xudong963 commented on code in PR #15366:
URL: https://github.com/apache/datafusion/pull/15366#discussion_r2010207806
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -708,7 +708,7 @@ pub fn try_type_union_resolution_with_struct(
/// strings. For example when comparing `'2' > 1`, the arguments will be
/// coerced to `Utf8` for comparison
pub fn comparison_coercion(lhs_type: &DataType, rhs_type: &DataType) ->
Option<DataType> {
- if lhs_type == rhs_type {
+ if lhs_type.equals_datatype(rhs_type) {
Review Comment:
👍
I also want to ping @jayzhan211 , He corrected me about a similar thing
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
