alamb commented on code in PR #15341:
URL: https://github.com/apache/datafusion/pull/15341#discussion_r2008804758
##########
datafusion/optimizer/tests/optimizer_integration.rs:
##########
@@ -267,8 +267,8 @@ fn push_down_filter_groupby_expr_contains_alias() {
let sql = "SELECT * FROM (SELECT (col_int32 + col_uint32) AS c, count(*)
FROM test GROUP BY 1) where c > 3";
let plan = test_sql(sql).unwrap();
let expected = "Projection: test.col_int32 + test.col_uint32 AS c,
count(Int64(1)) AS count(*)\
- \n Aggregate: groupBy=[[test.col_int32 + CAST(test.col_uint32 AS
Int32)]], aggr=[[count(Int64(1))]]\
- \n Filter: test.col_int32 + CAST(test.col_uint32 AS Int32) > Int32(3)\
+ \n Aggregate: groupBy=[[CAST(test.col_int32 AS Int64) +
CAST(test.col_uint32 AS Int64)]], aggr=[[count(Int64(1))]]\
Review Comment:
this might be slower-- as now the larger column type is used (so it needs to
do a 64 bit comparison rather than 32 bit) 🤔
##########
datafusion/optimizer/tests/optimizer_integration.rs:
##########
@@ -267,8 +267,8 @@ fn push_down_filter_groupby_expr_contains_alias() {
let sql = "SELECT * FROM (SELECT (col_int32 + col_uint32) AS c, count(*)
FROM test GROUP BY 1) where c > 3";
let plan = test_sql(sql).unwrap();
let expected = "Projection: test.col_int32 + test.col_uint32 AS c,
count(Int64(1)) AS count(*)\
- \n Aggregate: groupBy=[[test.col_int32 + CAST(test.col_uint32 AS
Int32)]], aggr=[[count(Int64(1))]]\
- \n Filter: test.col_int32 + CAST(test.col_uint32 AS Int32) > Int32(3)\
+ \n Aggregate: groupBy=[[CAST(test.col_int32 AS Int64) +
CAST(test.col_uint32 AS Int64)]], aggr=[[count(Int64(1))]]\
Review Comment:
but it probably also doesn't lose precision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
