Omega359 commented on code in PR #15341:
URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007630685
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -855,21 +855,14 @@ pub fn binary_numeric_coercion(
(UInt64, _) | (_, UInt64) => Some(UInt64),
(Int64, _)
| (_, Int64)
- | (UInt32, Int8)
- | (Int8, UInt32)
- | (UInt32, Int16)
- | (Int16, UInt32)
- | (UInt32, Int32)
- | (Int32, UInt32) => Some(Int64),
Review Comment:
Yes. It cannot go to Int32 because uInt32 has larger values than Int32. It
cannot go to UInt32 because Int can go negative. The most appropriate option
here is Int64 since that encloses all possible values for UInt32 and Int32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
