milenkovicm commented on PR #1212: URL: https://github.com/apache/datafusion-ballista/pull/1212#issuecomment-2741214382
apparently you found another bug: https://github.com/apache/datafusion-ballista/blob/bb10a1bebd52ebb91515efa7a2a977df740c2d7a/ballista/scheduler/src/scheduler_server/grpc.rs#L127 maybe if it is changed to: ```rust for (_, task) in schedulable_tasks { match self .state .task_manager .prepare_task_definition(task.clone()) { Ok(task_definition) => tasks.push(task_definition), Err(e) => { let job_id = task.partition.job_id; error!( "Error preparing task for job_id: {} error: {:?} ", job_id, e.to_string(), ); let _ = self .state .task_manager .abort_job(&job_id, e.to_string()) .await; } } } ``` whole job gets cancelled in case of error, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
