kazuyukitanimura commented on code in PR #1456:
URL: https://github.com/apache/datafusion-comet/pull/1456#discussion_r2001465890
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -61,13 +61,15 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
logWarning(s"Comet native execution is disabled due to: $reason")
}
- def supportedDataType(dt: DataType, allowStruct: Boolean = false): Boolean =
dt match {
+ def supportedDataType(dt: DataType, allowComplex: Boolean = false): Boolean
= dt match {
case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
_: DoubleType | _: StringType | _: BinaryType | _: TimestampType | _:
TimestampNTZType |
_: DecimalType | _: DateType | _: BooleanType | _: NullType =>
true
- case s: StructType if allowStruct =>
- s.fields.map(_.dataType).forall(supportedDataType(_, allowStruct))
+ case s: StructType if allowComplex =>
+ s.fields.map(_.dataType).forall(supportedDataType(_, allowComplex))
+ // case a: ArrayType if allowComplex =>
Review Comment:
I assume this will be done in the future.
Do you mind adding a TODO comment or file a follow up issue ticket?
##########
native/core/Cargo.toml:
##########
@@ -77,6 +77,7 @@ jni = { version = "0.21", features = ["invocation"] }
lazy_static = "1.4"
assertables = "7"
hex = "0.4.3"
+datafusion-functions-nested = "46.0.0"
Review Comment:
can we make it to `workspace = true` so that we do not forget to update here
when we upgrade DF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
