kosiew commented on code in PR #1036:
URL:
https://github.com/apache/datafusion-python/pull/1036#discussion_r2002243419
##########
python/tests/test_dataframe.py:
##########
@@ -1191,13 +1192,17 @@ def add_with_parameter(df_internal, value: Any) ->
DataFrame:
def test_dataframe_repr_html(df) -> None:
output = df._repr_html_()
Review Comment:
Would it be a good idea to test for other df fixtures too?
In addition, maybe add an empty_df fixture for tests too
eg
```
@pytest.fixture
def empty_df():
ctx = SessionContext()
# Create an empty RecordBatch with the same schema as df
batch = pa.RecordBatch.from_arrays(
[
pa.array([], type=pa.int64()),
pa.array([], type=pa.int64()),
pa.array([], type=pa.int64()),
],
names=["a", "b", "c"],
)
return ctx.from_arrow(batch)
@pytest.mark.parametrize(
"dataframe_fixture",
["empty_df", "df", "nested_df", "struct_df", "partitioned_df",
"aggregate_df"],
)
def test_dataframe_repr_html(request, dataframe_fixture) -> None:
df = request.getfixturevalue(dataframe_fixture)
output = df._repr_html_()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
