comphead commented on code in PR #14967:
URL: https://github.com/apache/datafusion/pull/14967#discussion_r1996412978
##########
datafusion/core/tests/parquet/filter_pushdown.rs:
##########
@@ -65,7 +65,12 @@ fn generate_file(tempdir: &TempDir, props: WriterProperties)
-> TestParquetFile
test_parquet_file
}
-#[tokio::test]
+// The result can be flaky if `rand` crate updated.
+//
+// Reason: Data generated by
Review Comment:
These fuzzy tests based random data gen become non relevant because of
`rand` version upgrade and seems the seed now returns different random,
different from what tests expect in terms of data distribution, column data,
etc making the test useless. Considering the Filter Pushdown is important test
and conditions in the tests are carefully chosen to cover use cases, we
probably materialize the parquet file and get rid of random data gen to avoid
test to be stale when `rand` crate upgraded.
@mbrobbel WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
