alamb commented on code in PR #15163: URL: https://github.com/apache/datafusion/pull/15163#discussion_r1996232099
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -739,43 +736,42 @@ physical_plan 01)┌───────────────────────────┐ 02)│ ProjectionExec │ 03)│ -------------------- │ -04)│ rolling_sum: │ -05)│ sum(t1.v1) ORDER BY [t1.v1│ -06)│ ASC NULLS LAST] ROWS │ -07)│ BETWEEN 1 PRECEDING │ -08)│ AND CURRENT ROW@1 │ -09)│ │ -10)│ v1: v1@0 │ -11)└─────────────┬─────────────┘ -12)┌─────────────┴─────────────┐ -13)│ BoundedWindowAggExec │ -14)│ -------------------- │ -15)│ mode: Sorted │ -16)│ │ -17)│ select_list: │ -18)│ sum(t1.v1) ORDER BY [t1.v1│ -19)│ ASC NULLS LAST] ROWS │ -20)│ BETWEEN 1 PRECEDING │ -21)│ AND CURRENT ROW │ -22)└─────────────┬─────────────┘ -23)┌─────────────┴─────────────┐ -24)│ SortExec │ -25)│ -------------------- │ -26)│ v1@0 ASC NULLS LAST │ -27)└─────────────┬─────────────┘ -28)┌─────────────┴─────────────┐ -29)│ ProjectionExec │ -30)│ -------------------- │ -31)│ v1: value@0 │ -32)└─────────────┬─────────────┘ -33)┌─────────────┴─────────────┐ -34)│ LazyMemoryExec │ -35)│ -------------------- │ -36)│ batch_generators: │ -37)│ generate_series: start=1, │ -38)│ end=1000, batch_size │ -39)│ =8192 │ -40)└───────────────────────────┘ +04)│ sum(t1.v1) ORDER BY [t1.v1│ +05)│ ASC NULLS LAST] ROWS │ +06)│ BETWEEN 1 PRECEDING │ +07)│ AND CURRENT ROW │ +08)│ │ +09)│ v1 │ +10)└─────────────┬─────────────┘ +11)┌─────────────┴─────────────┐ +12)│ BoundedWindowAggExec │ +13)│ -------------------- │ +14)│ mode: Sorted │ +15)│ │ +16)│ select_list: │ +17)│ sum(t1.v1) ORDER BY [t1.v1│ +18)│ ASC NULLS LAST] ROWS │ +19)│ BETWEEN 1 PRECEDING │ +20)│ AND CURRENT ROW │ +21)└─────────────┬─────────────┘ +22)┌─────────────┴─────────────┐ +23)│ SortExec │ +24)│ -------------------- │ +25)│ v1@0 ASC NULLS LAST │ Review Comment: Maybe we can file a follow on PR to improve other plans 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
