alamb commented on code in PR #15163: URL: https://github.com/apache/datafusion/pull/15163#discussion_r1996802719
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -704,29 +704,26 @@ physical_plan 01)┌───────────────────────────┐ 02)│ ProjectionExec │ 03)│ -------------------- │ -04)│ count(*) ROWS BETWEEN │ -05)│ UNBOUNDED PRECEDING │ -06)│ AND UNBOUNDED FOLLOWING: │ -07)│ count(Int64(1)) ROWS │ -08)│ BETWEEN UNBOUNDED │ -09)│ PRECEDING AND UNBOUNDED │ -10)│ FOLLOWING@0 │ -11)└─────────────┬─────────────┘ -12)┌─────────────┴─────────────┐ -13)│ WindowAggExec │ -14)│ -------------------- │ -15)│ select_list: │ -16)│ count(Int64(1)) ROWS │ -17)│ BETWEEN UNBOUNDED │ -18)│ PRECEDING AND UNBOUNDED │ -19)│ FOLLOWING │ -20)└─────────────┬─────────────┘ -21)┌─────────────┴─────────────┐ -22)│ DataSourceExec │ -23)│ -------------------- │ -24)│ files: 1 │ -25)│ format: csv │ -26)└───────────────────────────┘ +04)│ count(Int64(1)) ROWS │ Review Comment: > I'm not sure if this idea is correct. If you have any suggestions, that would be even better.❤️ I am not sure either -- maybe we can try it and see how it looks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
