andygrove commented on code in PR #1443:
URL: https://github.com/apache/datafusion-comet/pull/1443#discussion_r1996051635
##########
native/core/src/parquet/mod.rs:
##########
@@ -645,65 +653,42 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
.get_string(&JString::from_raw(file_path))
.unwrap()
.into();
- let batch_stream: Option<SendableRecordBatchStream>;
- // TODO: (ARROW NATIVE) Use the common global runtime
+
let runtime = tokio::runtime::Builder::new_multi_thread()
.enable_all()
.build()?;
let session_ctx = SessionContext::new();
+
let (object_store_url, object_store_path) =
- prepare_object_store(session_ctx.runtime_env(), path.clone())?;
+ prepare_object_store(session_ctx.runtime_env(),
path.clone()).unwrap();
Review Comment:
This should be `?` and the function should return a `Result`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
