andygrove commented on code in PR #15168: URL: https://github.com/apache/datafusion/pull/15168#discussion_r1995461595
########## datafusion/sqllogictest/test_files/spark/math/expm1.slt: ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + Review Comment: Here is my suggestion. 1. Write a Python script that generates interesting test data (probably in Parquet format) with edge cases using PySpark 2. Create files containing SQL queries that operate on these test files 3. Write a Python script to run those queries via PySpark and write results out to file 4. Write a Rust script to run those queries using datafusion-spark and write results out to file 5. Write a script that can compare the Spark and datafusion-spark output and report on any differences -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
