irenjj opened a new issue, #15252:
URL: https://github.com/apache/datafusion/issues/15252
The output of `AggregateExec` also seems to contain redundant
information.
I debugged the code and found that the name of `AggregateFunctionExpr` is
constructed in `create_aggregate_expr_and_maybe_filter`. In this function,
debug information is generated for all `Expr` instances through `Expr`'s
`SchemaDisplay`.
To address this issue, I propose the following solution:
1. Add a new member `sql_name` to `AggregateFunctionExpr`.
2. Introduce a new method `fmt_sql_name()` for `Expr`, similar to
`schema_name()`, and override it in `AggregateFunction` to generate `sql_name`.
3. Modify `fmt_as` in `AggregateExec` to output `aggr_expr.sql_name` instead
of `aggr_expr.name`.
I'm not sure if this idea is correct. If you have any suggestions, that
would be even better.❤️
_Originally posted by @irenjj in
https://github.com/apache/datafusion/pull/15163#discussion_r1996678781_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
