Omega359 commented on PR #15242: URL: https://github.com/apache/datafusion/pull/15242#issuecomment-2726752609
I had issues with github this morning so here is a patch to get tests running: ``` Index: datafusion/sql/tests/sql_integration.rs IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/datafusion/sql/tests/sql_integration.rs b/datafusion/sql/tests/sql_integration.rs --- a/datafusion/sql/tests/sql_integration.rs (revision 5d9cca60d65e5f988c3c383c781de6903d190bf1) +++ b/datafusion/sql/tests/sql_integration.rs (revision 27d0f85595804c7163f8adad90af6ff20f96fd4f) @@ -1901,8 +1901,9 @@ \n Projection: NULL AS Int64(1), order_id\ \n Projection: orders.order_id\ \n TableScan: orders\ - \n Projection: orders.order_id, Int64(1)\ - \n TableScan: orders"; + \n Projection: Int64(1), order_id\ + \n Projection: orders.order_id, Int64(1)\ + \n TableScan: orders"; quick_test(sql, expected); } @@ -1939,19 +1940,23 @@ \n Projection: NULL AS Int64(1), order_id\ \n Projection: orders.order_id\ \n TableScan: orders\ - \n Projection: orders.order_id, Int64(1)\ - \n TableScan: orders"; + \n Projection: Int64(1), order_id\ + \n Projection: orders.order_id, Int64(1)\ + \n TableScan: orders"; quick_test(sql, expected); } #[test] fn union_all_by_name_same_column_names() { let sql = "SELECT order_id from orders UNION ALL BY NAME SELECT order_id FROM orders"; - let expected = "Union\ - \n Projection: orders.order_id\ - \n TableScan: orders\ - \n Projection: orders.order_id\ - \n TableScan: orders"; + let expected = "\ + Union\ + \n Projection: order_id\ + \n Projection: orders.order_id\ + \n TableScan: orders\ + \n Projection: order_id\ + \n Projection: orders.order_id\ + \n TableScan: orders"; quick_test(sql, expected); } Index: datafusion/sqllogictest/test_files/union_by_name.slt IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/datafusion/sqllogictest/test_files/union_by_name.slt b/datafusion/sqllogictest/test_files/union_by_name.slt --- a/datafusion/sqllogictest/test_files/union_by_name.slt (revision 5d9cca60d65e5f988c3c383c781de6903d190bf1) +++ b/datafusion/sqllogictest/test_files/union_by_name.slt (revision 27d0f85595804c7163f8adad90af6ff20f96fd4f) @@ -315,3 +315,21 @@ ---- a b c NULL a b c d + +query TTT rowsort +select x, y, z from t3 union all by name select z, y, x from t3; +---- +a b c +a b c + +query TTT rowsort +select x, y, z from t3 union all by name select z, y, x from t4; +---- +a b c +a b c + +query TTT rowsort +select x, y, z from t3 union all by name select z, y, x from t4 order by x; +---- +a b c +a b c ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org