iffyio commented on code in PR #1755:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1755#discussion_r1995813212
##########
tests/sqlparser_snowflake.rs:
##########
@@ -976,6 +976,27 @@ fn parse_sf_create_or_replace_with_comment_for_snowflake()
{
}
}
+#[test]
+fn parse_sf_create_table_or_view_with_dollar_quoted_comment() {
+ assert!(snowflake()
+ .parse_sql_statements(
+ r#"CREATE OR REPLACE TEMPORARY VIEW foo.bar.baz (
+ "COL_1" COMMENT $$comment 1$$
+ ) COMMENT = $$view comment$$ AS (
+ SELECT 1
+ )"#
+ )
+ .is_ok());
+
+ assert!(snowflake()
+ .parse_sql_statements(
+ r#"CREATE TABLE my_table (
+ a STRING COMMENT $$comment 1$$
+ ) COMMENT = $$table comment$$"#
+ )
Review Comment:
Ah that makes sense, I think we can leave as is in that case in order to
limit the scope of the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
