jonahgao commented on code in PR #15153: URL: https://github.com/apache/datafusion/pull/15153#discussion_r1995820915
########## datafusion/core/tests/sql/select.rs: ########## @@ -350,3 +350,45 @@ async fn test_version_function() { assert_eq!(version.value(0), expected_version); } + +#[tokio::test] +async fn test_subscript() -> Result<()> { Review Comment: This is more suitable as a sqllogictest test. Maybe we can move it to [struct.slt](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/struct.slt) or [identifiers.slt](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/identifiers.slt) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org