alamb commented on PR #15143: URL: https://github.com/apache/datafusion/pull/15143#issuecomment-2722676495
> > I took the liberty of merging this PR up from main and fixing the tests as I had it checked out already > > Many thanks to @alamb for taking the time to review my testing issues. I'll try to become more familiar with the test pyramid in the future and test it thoroughly before pushing out changes. No worries! Your next PRs will also automatically run CI checks which will help As a helpful hint, locally i have found running ```shell cargo test --test sqllogictests cargo nextest run ``` Will catch almost all test related issues Catches almost all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
