blaginin commented on code in PR #15165:
URL: https://github.com/apache/datafusion/pull/15165#discussion_r1991548161
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -429,16 +434,16 @@ async fn drop_with_quotes() -> Result<()> {
let df_results = df.collect().await?;
- assert_batches_sorted_eq!(
Review Comment:
that is very very fair! initially i
[wanted](https://github.com/blaginin/datafusion/compare/switch-to-insta...blaginin:datafusion:switch-to-insta-sorted?expand=1#diff-4a599584dfc900ec21169f4f820a1b1db46b004b77533dab83a6178d5d3a467eR467)
to sort by all columns present in the df - but the issue is that not all types
are sortable
I also considered sorting by something like
https://docs.rs/human-sort/latest/human_sort/ - but then again, it's +1 extra
dev dependency...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
