alamb commented on code in PR #15125: URL: https://github.com/apache/datafusion/pull/15125#discussion_r1987795755
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -674,17 +674,16 @@ physical_plan 23)┌─────────────┴─────────────┐ 24)│ SortExec │ 25)│ -------------------- │ -26)│ sort keys: │ -27)│ [v1@0 ASC NULLS LAST] │ -28)└─────────────┬─────────────┘ -29)┌─────────────┴─────────────┐ -30)│ ProjectionExec │ -31)│ -------------------- │ -32)│ v1: value@0 │ -33)└─────────────┬─────────────┘ -34)┌─────────────┴─────────────┐ -35)│ LazyMemoryExec │ -36)└───────────────────────────┘ +26)│ v1@0 ASC NULLS LAST │ Review Comment: that is very nice ########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -1232,20 +1223,22 @@ logical_plan 03)--TableScan: table2 projection=[int_col, string_col, bigint_col, date_col] physical_plan 01)┌───────────────────────────┐ -02)│ CrossJoinExec ├──────────────┐ -03)└─────────────┬─────────────┘ │ -04)┌─────────────┴─────────────┐┌─────────────┴─────────────┐ -05)│ DataSourceExec ││ RepartitionExec │ -06)│ -------------------- ││ │ -07)│ files: 1 ││ │ -08)│ format: csv ││ │ -09)└───────────────────────────┘└─────────────┬─────────────┘ -10)-----------------------------┌─────────────┴─────────────┐ -11)-----------------------------│ DataSourceExec │ -12)-----------------------------│ -------------------- │ -13)-----------------------------│ files: 1 │ -14)-----------------------------│ format: parquet │ -15)-----------------------------└───────────────────────────┘ +02)│ CrossJoinExec │ +03)│ -------------------- ├──────────────┐ +04)│ CrossJoinExec │ │ Review Comment: this second CrossJoinExec seems strange to me ########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -1232,20 +1223,22 @@ logical_plan 03)--TableScan: table2 projection=[int_col, string_col, bigint_col, date_col] physical_plan 01)┌───────────────────────────┐ -02)│ CrossJoinExec ├──────────────┐ -03)└─────────────┬─────────────┘ │ -04)┌─────────────┴─────────────┐┌─────────────┴─────────────┐ -05)│ DataSourceExec ││ RepartitionExec │ -06)│ -------------------- ││ │ -07)│ files: 1 ││ │ -08)│ format: csv ││ │ -09)└───────────────────────────┘└─────────────┬─────────────┘ -10)-----------------------------┌─────────────┴─────────────┐ -11)-----------------------------│ DataSourceExec │ -12)-----------------------------│ -------------------- │ -13)-----------------------------│ files: 1 │ -14)-----------------------------│ format: parquet │ -15)-----------------------------└───────────────────────────┘ +02)│ CrossJoinExec │ +03)│ -------------------- ├──────────────┐ +04)│ CrossJoinExec │ │ Review Comment: I fixed this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
