alan910127 commented on PR #15110: URL: https://github.com/apache/datafusion/pull/15110#issuecomment-2716046223
> I don't think the source of the cast matters (for this particular optimization) Ah, yes. Since the string -> int -> string is checked and we're only checking equality, then they'll be the same. But I' m not sure if this unwrapping would happen after the string literal coercion. > That is my understanding and also what I think should happen Got it, should I revert this PR to the unwrap cast optimization or directly combine both the optimization and the literal coercion in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
