Jiashu-Hu opened a new pull request, #15142: URL: https://github.com/apache/datafusion/pull/15142
…revent this specific situation ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #[15047](https://github.com/apache/datafusion/issues/15047). ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> This PR fixes a bug in PushDownFilter where a Filter node is incorrectly removed when its child is an extension node with no inputs (e.g., Filter: false -> TestNode becomes TestNode). This change ensures the Filter is preserved in such cases to maintain the intended query logic. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Modified the rewrite method in PushDownFilter to add a specific check for LogicalPlan::Extension nodes with no children. When an extension node has no inputs, the Filter is kept by resetting its input and returning it unchanged using Transformed::no. ## Are these changes tested? Yes, the changes are tested with an updated unit test test_push_down_filter_to_user_defined_node that: Creates a TestUserNode (an extension node with no inputs). Applies a Filter with a constant expression (false). Verifies the optimized plan retains the Filter instead of removing it. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? No, this is an internal optimization fix and does not alter the public API or user-facing behavior. It only ensures correct query execution for plans involving extension nodes with no children. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
