joroKr21 commented on code in PR #10790:
URL: https://github.com/apache/datafusion/pull/10790#discussion_r1987078389
##########
datafusion/functions-array/src/make_array.rs:
##########
@@ -131,6 +131,11 @@ impl ScalarUDFImpl for MakeArray {
}
}
+// Empty array is a special case that is useful for many other array functions
+pub(super) fn empty_array_type() -> DataType {
+ DataType::List(Arc::new(Field::new("item", DataType::Int64, true)))
+}
Review Comment:
I don't get the rationale behind that. From type-theoretical point of view,
an empty array has type `Array<Null>` because you can coerce `Null` to any
other type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
