alamb commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1985679028
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -5818,6 +5818,13 @@ false false false false
false false false false
false false false false
+query BB
Review Comment:
this query passes on main for me. In other words I don't think the test
covers the bug fix 🤔
```sql
DataFusion CLI v46.0.0
> select array_has_all(make_array(1,2,3), []),
array_has_any(make_array(1,2,3), []);
+--------------------------------------------------------------------+--------------------------------------------------------------------+
| array_has_all(make_array(Int64(1),Int64(2),Int64(3)),make_array()) |
array_has_any(make_array(Int64(1),Int64(2),Int64(3)),make_array()) |
+--------------------------------------------------------------------+--------------------------------------------------------------------+
| true | false
|
+--------------------------------------------------------------------+--------------------------------------------------------------------+
1 row(s) fetched.
Elapsed 0.024 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
