alamb commented on code in PR #15031:
URL: https://github.com/apache/datafusion/pull/15031#discussion_r1984108991


##########
datafusion/physical-plan/Cargo.toml:
##########
@@ -63,6 +63,8 @@ log = { workspace = true }
 parking_lot = { workspace = true }
 pin-project-lite = "^0.2.7"
 tokio = { workspace = true }
+unicode-segmentation = "1.10"

Review Comment:
   Rust can still find unicode character boundaries via `str::chars()` but, it 
just might split them on non printing characters, etc.
   
   I suggest we wait until we have some actual example of such a malformed plan 
before adding the new dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to