comphead commented on code in PR #15031:
URL: https://github.com/apache/datafusion/pull/15031#discussion_r1983603313


##########
datafusion/physical-plan/Cargo.toml:
##########
@@ -63,6 +63,8 @@ log = { workspace = true }
 parking_lot = { workspace = true }
 pin-project-lite = "^0.2.7"
 tokio = { workspace = true }
+unicode-segmentation = "1.10"

Review Comment:
   Adding more dependencies to the core making the binary size bigger, and if 
this is for formatting wondering if its possible to do the same without extra 
deps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to