alamb commented on code in PR #15054:
URL: https://github.com/apache/datafusion/pull/15054#discussion_r1983974995
##########
benchmarks/README.md:
##########
@@ -329,7 +329,37 @@ Your benchmark should create and use an instance of
`BenchmarkRun` defined in `b
# Benchmarks
-The output of `dfbench` help includes a description of each benchmark, which
is reproduced here for convenience
+The output of `dfbench` help includes a description of each benchmark, which
is reproduced here for convenience.
+
+## Cancellation
Review Comment:
❤️
##########
benchmarks/src/cancellation.rs:
##########
@@ -97,7 +100,7 @@ impl RunOpt {
println!("Done loading data into in-memory object store");
let mut rundata = BenchmarkRun::new();
- rundata.start_new_case("Arglebargle");
+ rundata.start_new_case("Cancellation");
Review Comment:
🤦 -- sorry about that.
Though today I have learned a new placeholder word!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
