jonahgao commented on issue #14999: URL: https://github.com/apache/datafusion/issues/14999#issuecomment-2704274608
> After optimisation, `expressions()` will return a `Vec<Expr::Column>` which come from the equi pairs in the `on` field of the `Join`. Should `with_new_exprs` be updated to handle `Column`s? It will need to expect them to come in pairs to build the new `on` out of them Or, return each `on` pair as a `BinaryExpr` from `expressions()`? I think we should update `with_new_exprs()`, so there is no need to construct a temporary `BinaryExpr`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
