kazuyukitanimura commented on code in PR #1456:
URL: https://github.com/apache/datafusion-comet/pull/1456#discussion_r1982384947
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -60,14 +60,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
logWarning(s"Comet native execution is disabled due to: $reason")
}
- def supportedDataType(dt: DataType, allowStruct: Boolean = false): Boolean =
dt match {
+ def supportedDataType(dt: DataType, allowComplex: Boolean = false): Boolean
= dt match {
case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
_: DoubleType | _: StringType | _: BinaryType | _: TimestampType | _:
DecimalType |
_: DateType | _: BooleanType | _: NullType =>
true
case dt if isTimestampNTZType(dt) => true
- case s: StructType if allowStruct =>
- s.fields.map(_.dataType).forall(supportedDataType(_, allowStruct))
+ case s: StructType if allowComplex =>
+ s.fields.map(_.dataType).forall(supportedDataType(_, allowComplex))
+ case a: ArrayType if allowComplex =>
+ supportedDataType(a.elementType)
Review Comment:
Do we need to pass `allowComplex` recursively here like
`supportedDataType(a.elementType, allowComplex)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
