wiedld opened a new issue, #15003: URL: https://github.com/apache/datafusion/issues/15003
### Is your feature request related to a problem or challenge? We have two primary goals: (1) ensure the test coverage includes use cases we encounter in prod, and (2) make the existing test suite easier to understand. ### Describe the solution you'd like For the existing tests: - [ ] use an easier to read formatting of plans - [ ] convert the [existing macro with up to 8 vargs](https://github.com/apache/datafusion/blob/6c95b562cba95fdce90090b92657a6b464587bda/datafusion/core/tests/physical_optimizer/enforce_distribution.rs#L374-L403), into something easier to reason about (e.g. builder pattern, etc) For the improved test coverage: - [ ] have test cases we we are not using batch_size=1 ([existing test cases hardcode it to =1 to force roundrobin repartitioning](https://github.com/influxdata/arrow-datafusion/blob/2fcab2ef0da474ec000d7410427b9d18afb5820b/datafusion/core/tests/physical_optimizer/enforce_distribution.rs#L404-L405)). - [ ] have test cases include data source with statistics, otherwise we [always hit this branch point](https://github.com/influxdata/arrow-datafusion/blob/2fcab2ef0da474ec000d7410427b9d18afb5820b/datafusion/physical-optimizer/src/enforce_distribution.rs#L1118), which often forces roundrobin repartitiong. - [ ] have test cases without join key reordering, otherwise we [never hit this branch](https://github.com/influxdata/arrow-datafusion/blob/2fcab2ef0da474ec000d7410427b9d18afb5820b/datafusion/physical-optimizer/src/enforce_distribution.rs#L209-L213). ### Describe alternatives you've considered N/A ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
