alamb commented on issue #14991:
URL: https://github.com/apache/datafusion/issues/14991#issuecomment-2697939824

   In the case where the data is already sorted on the group expressions, it 
should use a different grouping operator, specifically
   
https://docs.rs/datafusion/latest/datafusion/physical_plan/aggregates/order/struct.GroupOrderingFull.html
   
   I don't think `GroupOrderingFull` even uses GroupsAccumulator (it just uses 
Accumulator I think)
   
   So in other words, I don't think passing the order to groups accumulator 
will help
   
   
   There is another version where the data is grouped on a prefix of the 
grouping keys: 
https://docs.rs/datafusion/latest/datafusion/physical_plan/aggregates/order/struct.GroupOrderingPartial.html
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to