mvzink commented on PR #1746: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1746#issuecomment-2686444775
If you are considering overhauling and fleshing out support for table options, I would be strongly in favor of making them work like column options: i.e. a `Vec` of options that can be parsed and rendered in any order. See `Parser::parse_optional_column_option` and its various usages. It would also be easier to have parity with `CREATE TABLE` and `ALTER TABLE` that way (both could just include a `Vec<TableOption>` or whatever). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
