comphead commented on code in PR #14843: URL: https://github.com/apache/datafusion/pull/14843#discussion_r1971913507
########## Cargo.toml: ########## @@ -159,19 +159,20 @@ url = "2.5.4" [profile.release] codegen-units = 1 lto = true +debug = false +strip = true +panic = "abort" Review Comment: I rolled back the panic behavior. it is only the strip added which is safe. Panic compilation behavior is also applied to dependencies which can be shoot in the foot, and this parameter is not overridable on crate level https://doc.rust-lang.org/cargo/reference/profiles.html#overrides ``` Overrides cannot specify the panic, lto, or rpath settings. ``` Although it saves addition 15-20% I dont think we can use it in near future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
