alamb opened a new pull request, #14898: URL: https://github.com/apache/datafusion/pull/14898
## Which issue does this PR close? - Related to https://github.com/delta-io/delta-rs/pull/3261 - Related to https://github.com/apache/datafusion/issues/14123 - Follow on to https://github.com/apache/datafusion/pull/14224 ## Rationale for this change While working on upgrading DataFusion 46 in several projects, I found the name `source` super confusing The issue is there are two similarly named traits, `FileSource` and `DataSource` but several functions / fields are named just `source` so it is not clear which they refer to This was especially confusing as `DataSourceExec` has a `DataSource` which is a `FileScanConfig` not the `FileSOurce` (which is a``ParquetSource` 🤯 ## What changes are included in this PR? 1. rename the fields and accessors to be explicitly `data_source` or `file_source` to avoid the confusion The documentation on how all these traits are related to each other is somewhat sparse. I am hoping to make a PR to improve it too ## Are these changes tested? By CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? While this is an API change, the releveant APIs were introduced in https://github.com/apache/datafusion/pull/14224 and thus not yet released, so I don't think this is explicitly a breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
