alamb opened a new issue, #14878:
URL: https://github.com/apache/datafusion/issues/14878
I lean towards having the default behaviour be `false` for
this, even if it's a breaking change, because it makes the builder less
surprising IMO. Specifically, when invoking the builder for an aggregate with a
specific set of grouping expressions, my expectation is that it should produce
an aggregate with those specific grouping expressions. If I wanted additional
grouping expressions, I would have included them.
There's definitely room and value for optimizations like what is going on
here, but I think those need to be opt-in to avoid situation like this were the
plan builder tries to be smart along one specific axis and inadvertently shoots
you in the foot in another. In the past, I think we've leaned towards having
the builder be as straightforward as possible and then handling optimizations
in the optimizer.
_Originally posted by @vbarua in
https://github.com/apache/datafusion/pull/14860#discussion_r1970267828_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
