kosiew commented on code in PR #1016:
URL:
https://github.com/apache/datafusion-python/pull/1016#discussion_r1969081210
##########
src/dataframe.rs:
##########
@@ -156,6 +174,22 @@ impl PyDataFrame {
PyArrowType(self.df.schema().into())
}
+ /// Convert this DataFrame into a Table that can be used in register_table
+ /// By convention, into_... methods consume self and return the new object.
+ /// Disabling the clippy lint, so we can use &self
+ /// because we're working with Python bindings
+ /// where objects are shared
+ #[allow(clippy::wrong_self_convention)]
+ fn into_view(&self) -> PyDataFusionResult<PyTable> {
+ // Call the underlying Rust DataFrame::into_view method.
+ // Note that the Rust method consumes self; here we clone the inner
Arc<DataFrame>
+ // so that we don’t invalidate this PyDataFrame.
+ let table_provider = self.df.as_ref().clone().into_view();
+ let table_provider = PyTableProvider::new(table_provider);
Review Comment:
```suggestion
let table_provider = PyTableProvider::new(table_provider);
```
##########
src/dataframe.rs:
##########
@@ -156,6 +174,22 @@ impl PyDataFrame {
PyArrowType(self.df.schema().into())
}
+ /// Convert this DataFrame into a Table that can be used in register_table
+ /// By convention, into_... methods consume self and return the new object.
+ /// Disabling the clippy lint, so we can use &self
+ /// because we're working with Python bindings
+ /// where objects are shared
+ #[allow(clippy::wrong_self_convention)]
+ fn into_view(&self) -> PyDataFusionResult<PyTable> {
+ // Call the underlying Rust DataFrame::into_view method.
+ // Note that the Rust method consumes self; here we clone the inner
Arc<DataFrame>
+ // so that we don’t invalidate this PyDataFrame.
+ let table_provider = self.df.as_ref().clone().into_view();
+ let table_provider = PyTableProvider::new(table_provider);
Review Comment:
```suggestion
let table_provider = PyTableProvider::new(table_provider);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
