AdamGS commented on code in PR #14838:
URL: https://github.com/apache/datafusion/pull/14838#discussion_r1968197144
##########
datafusion/datasource/Cargo.toml:
##########
@@ -69,6 +71,7 @@ xz2 = { version = "0.1", optional = true, features =
["static"] }
zstd = { version = "0.13", optional = true, default-features = false }
[dev-dependencies]
+datafusion = { workspace = true, default-features = true }
Review Comment:
seems like some was unnecessary, and some were already moved into
`memory.rs`, so I just moved it up under `#[cfg(test)]`.
##########
datafusion/datasource/Cargo.toml:
##########
@@ -69,6 +71,7 @@ xz2 = { version = "0.1", optional = true, features =
["static"] }
zstd = { version = "0.13", optional = true, default-features = false }
[dev-dependencies]
+datafusion = { workspace = true, default-features = true }
Review Comment:
seems like some were unnecessary, and some were already moved into
`memory.rs`, so I just moved it up under `#[cfg(test)]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
