alamb commented on code in PR #14838:
URL: https://github.com/apache/datafusion/pull/14838#discussion_r1967976268
##########
datafusion/datasource/Cargo.toml:
##########
@@ -69,6 +71,7 @@ xz2 = { version = "0.1", optional = true, features =
["static"] }
zstd = { version = "0.13", optional = true, default-features = false }
[dev-dependencies]
+datafusion = { workspace = true, default-features = true }
Review Comment:
Typically to avoid this type of dependnecy there are two options:
1. Rewrite the tests to not use stuff (like SessionContext) that are in the
core
2. Move the relevant tests somewhere into the core tests -- like
`datafusion/core/tests/sql_integration.rs`
##########
datafusion/core/Cargo.toml:
##########
@@ -40,7 +40,7 @@ nested_expressions = ["datafusion-functions-nested"]
# This feature is deprecated. Use the `nested_expressions` feature instead.
array_expressions = ["nested_expressions"]
# Used to enable the avro format
-avro = ["apache-avro", "num-traits", "datafusion-common/avro"]
+avro = ["apache-avro", "num-traits", "datafusion-common/avro",
"datafusion-datasource/avro"]
Review Comment:
I wonder if we can remove the avro stuff from datafusion-common 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
