rluvaton commented on code in PR #14841:
URL: https://github.com/apache/datafusion/pull/14841#discussion_r1966840711
##########
datafusion/functions/src/unicode/strpos.rs:
##########
@@ -83,6 +83,15 @@ impl ScalarUDFImpl for StrposFunc {
utf8_to_int_type(&arg_types[0], "strpos/instr/position")
Review Comment:
Keeping `return_type` function and not changing to `internal_err` as
suggested in the function docs to avoid breaking change + the `test_function`
macro uses it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
