rluvaton opened a new pull request, #14841:
URL: https://github.com/apache/datafusion/pull/14841

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   Currently because this function does not override `return_type_from_args`, 
it will return that the return type is always nullable however this is not 
true, as it is only nullable if any of the argument is nullable
   
   ## What changes are included in this PR?
   
   Implement `return_type_from_args` to return nullable true if any of the 
input is nullable and return an error for calls to return_type
   
   ## Are these changes tested?
   
   yes
   
   ## Are there any user-facing changes?
   
   yes, we will now be able to get if the result is actually nullable or not.
   
   There are breaking changes I think as we return an error if `return_type` 
function is called


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to