iffyio commented on PR #1707: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1707#issuecomment-2676183454
Ah I see thanks for clarifying! 1. I think introducing a `Custom` variant would be reasonable, it would be similar to the existing pattern of `DataType::Custom`, `BinaryOperator::Custom` etc that we have. The existing `Hash` and `BTree` I figure we can keep as is, represented explicitly, partily to avoid breaking changes more than necessary and also since those types are the most common index types across dialects 2. I don't think we need to check that, we can look to parse the operator class if one is present in the input. 3. I think we can keep `IndexType` as the enum in (1), then essentially operator class in (2) is an opaque `String`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
