PokIsemaine commented on issue #14514:
URL: https://github.com/apache/datafusion/issues/14514#issuecomment-2676170116

   > > I noticed [#7622](https://github.com/apache/datafusion/pull/7622), if 
the syntax was originally not supported by 
[sqlparser](https://github.com/apache/datafusion-sqlparser-rs), do I need to 
first submit a PR in the 
[sqlparser](https://github.com/apache/datafusion-sqlparser-rs) repository and 
then proceed with the implementation in datafusion? Or should we just go ahead 
with the implementation in datafusion?
   > 
   > Yes, you probably need to update `struct OrderBy` in sqlparser
   
   https://github.com/apache/datafusion-sqlparser-rs/pull/1724
   I updated `OrderBy` in `sqlparser` and made it support parsing of `ORDER BY 
ALL`, after the subsequent version is released, we can start implementing 
`ORDER BY ALL` for `datafusion`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to