alamb commented on code in PR #14798:
URL: https://github.com/apache/datafusion/pull/14798#discussion_r1965381239
##########
datafusion/core/src/datasource/data_source.rs:
##########
@@ -38,10 +38,10 @@ pub trait FileSource: Send + Sync {
/// Creates a `dyn FileOpener` based on given parameters
fn create_file_opener(
&self,
- object_store: datafusion_common::Result<Arc<dyn ObjectStore>>,
+ object_store: Arc<dyn ObjectStore>,
Review Comment:
I agree the old signature is very weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
