AdamGS commented on PR #14798: URL: https://github.com/apache/datafusion/pull/14798#issuecomment-2672394598
After some thought, I think removing the `Result` from the return value is also valuable here, there's basically only one callsite but at this point should just work. If we want to add more validation to parameters, IMO the place to add that is when we use `FileScanConfig` to configure the source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
