parthchandra commented on issue #1412: URL: https://github.com/apache/datafusion-comet/issues/1412#issuecomment-2668355055
Info on rust integer overflow: https://github.com/rust-lang/rfcs/blob/master/text/0560-integer-overflow.md ``` The operations +, -, *, can underflow and overflow. When checking is enabled this will panic. When checking is disabled this will two's complement wrap. The operations /, % for the arguments INT_MIN and -1 will unconditionally panic. This is unconditional for legacy reasons. Shift operations (<<, >>) on a value of width N can be passed a shift value >= N. It is unclear what behaviour should result from this, so the shift value is unconditionally masked to be modulo N to ensure that the argument is always in range. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
